perf: decode proposal id from tx resp #7785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duvbell
requested review from
AdityaSripal,
damiannolan and
gjermundgaraba
as code owners
gjermundgaraba
requested changes
Dec 22, 2024
| @@ -222,16 +222,13 @@ func (s *E2ETestSuite) ExecuteAndPassGovV1Beta1Proposal(ctx context.Context, cha | |||
| panic("ExecuteAndPassGovV1Beta1Proposal must be passed a cosmos.CosmosChain") | |||
| } | |||
|
|
|||
| proposalID := s.proposalIDs[chain.Config().ChainID] | |||
| defer func() { | |||
There was a problem hiding this comment.
I still think this is used somewhere else, so unless we can get rid of the whole s.proposalIDs, I think we still need the defer below line 231.
If you can easily get the proposalID for the other use and get rid of it entirely, that is preferable :)
There was a problem hiding this comment.
Hello @gjermundgaraba , i updated, can you help me review it?
There was a problem hiding this comment.
This looks correct to me! Thank you :)
duvbell
force-pushed
the
perf/decode-proposal-id-from-txresp
branch
from
1d704c3 to
18afeda
Compare
duvbell
force-pushed
the
perf/decode-proposal-id-from-txresp
branch
from
5678954 to
98341ea
Compare
gjermundgaraba
approved these changes
Dec 23, 2024
| @@ -222,16 +222,13 @@ func (s *E2ETestSuite) ExecuteAndPassGovV1Beta1Proposal(ctx context.Context, cha | |||
| panic("ExecuteAndPassGovV1Beta1Proposal must be passed a cosmos.CosmosChain") | |||
| } | |||
|
|
|||
| proposalID := s.proposalIDs[chain.Config().ChainID] | |||
| defer func() { | |||
There was a problem hiding this comment.
This looks correct to me! Thank you :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.